Message-Id: <199803111857.NAA17759@poconos.net>
Comments: Authenticated sender is <mibsoft@mailhost.epix.net>
From: "Forrest J. Cavalier III" <mibsoft@mibsoftware.com>
To: Chris van den Berg <usenet@agate.berkeley.edu>
Date: Wed, 11 Mar 1998 13:56:30 -0500
MIME-Version: 1.0
Subject: Re: ctlinnd feedinfo "sitename" causes 1.7.2+insync-d to crash?
Reply-to: mibsoft@mibsoftware.com
CC: inn-workers@vix.com, inn-patches@isc.org
Priority: normal
Sender: owner-inn-patches@vix.com
Precedence: bulk
Content-Type: Multipart/Mixed; boundary=Message-Boundary-12028


--Message-Boundary-12028
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body

> From:          Chris van den Berg <usenet@agate.berkeley.edu>
> To:            inn-bugs@isc.org
> Subject:       ctlinnd feedinfo "sitename" causes 1.7.2+insync-d to crash?

> Dunno if anyone's reported on this before...  Here's a backtrace from a
> core file.  innd crashed with signal 11, seg fault after issuing ctlinnd
> 

Hmmm.  Apparently that defect has been there a while..
...It only gets triggered when a channel is sleeping and
you run ctlinnd feedinfo.....

Thanks for reporting it and providing the backtrace!

Here's the patch.  For 1.5.1 (but anything after that
needs to be fixed also.)

Forrest

--Message-Boundary-12028
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Text from file 'msg'

--- innd/site.c	Tue Dec 17 05:40:40 1996
+++ innd/site.c	Wed Mar 11 13:55:28 1998
@@ -1217,7 +1217,7 @@
 		ctime(&cp->LastActive) + 4);
 	    p += strlen(p);
 	    if (cp->Waketime > Now.time) {
-		(void)sprintf("\tSleeping until %.12s\n",
+		(void)sprintf(p, "\tSleeping until %.12s\n",
 		    ctime(&cp->Waketime) + 4);
 		p += strlen(p);
 	    }

--Message-Boundary-12028--


-- End --