Date sent: Mon, 2 Mar 1998 09:48:13 +0100 From: Sven Paulus To: inn-patches@isc.org Copies to: ost@comnets.rwth-aachen.de Subject: Another little permission bug in nnrpd Martin Ostermann mentioned another problem with permissions in nnrpd on the German Newsmaster Mailing List, the affected command is XGTITLE. This patch should solve it: --- nnrpd/group.c.orig Fri Dec 12 17:43:47 1997 +++ nnrpd/group.c Mon Mar 2 10:52:15 1998 @@ -627,6 +627,7 @@ register char *p; register char *q; char save; + char *grplist[2]; /* Parse the arguments. */ if (ac == 1) { @@ -646,6 +647,7 @@ return; } Printf("%d list follows\r\n", NNTP_XGTITLE_OK); + grplist[1] = NULL; /* Print all lines with matching newsgroup name. */ while ((line = QIOread(qp)) != NULL) { @@ -653,7 +655,8 @@ continue; save = *q; *q = '\0'; - if (wildmat(line, p)) { + grplist[0] = line; + if (wildmat(line, p) && PERMmatch(PERMdefault, PERMlist, grplist)) { *q = save; Printf("%s\r\n", line); } Sven -- --Sven-Paulus----------28-48-32--3-----ub6v@rz.uni-karlsruhe.de------ --Karlstr.-55----------30--2-50-29-----sven@oops.sub.de-------------- --D-76133-Karlsruhe----44-49-10--8-----T#-49-721-9375094---------irc- --PGP-ID-3C9A6091-------9-12-19-71-----F#-49-721-9375095-----svennie-