Subject: INN 1.7.2 Bug Report - XBATCH related
To: [email-masked]

Date sent:        Wed, 25 Feb 1998 15:13:42 +0100 (MET)
Copies to:        [email-masked], [email-masked], [email-masked]
From:             [email-masked] (Andreas Vogel)
Send reply to:    [email-masked]

Hello,

hereby I want to submit a bug report for inn 1.7.2. The bug
shows up when receiving batches via the XBATCH command. The
first batch is received properly while any following batches
are discarded due to protocol errors.

The cause for this bug is quite simple: in innd/nc.c,
where the xbatch protocol state machine is located, the statement
for resetting the state after receiving a xbatch is missing.

My (verified) solution is (as a context diff):

*** innd/nc.c.ORIG   Tue Feb 24 10:59:03 1998
--- innd/nc.c        Wed Feb 25 14:02:06 1998
***************
*** 1271,1276 ****
--- 1271,1277 ----
	    bp->Used = 0;
	    bp->Data = NEW(char, bp->Size);
  #endif
+           cp->State = CSgetcmd;
	    break;
	}
	if (Tracing || cp->Tracing)

Without this patch you won't be able to receive more than one
xbatch in a row.

Greetings,

Andreas

-- 
		 _       __ Südhalde 4 / 73732 Esslingen / Germany
Andreas Vogel   / \     /   Voice:  +49-711/9371742
	       /___\   /    FAX:    +49-711/9371745
______________/     \_/     E-Mail: [email-masked]